Ruby Critic

Updated 2017-07-30 10:07:28 +0100

app/controllers/admin / petition_tags_controller.rb

25 lines of codes

4 methods

3.2 complexity/method

2 churn

12.85 complexity

0 duplications

code
2 smells

class Admin::PetitionTagsController < Admin::AdminController                                        InstanceVariableAssumption              
      Admin::PetitionTagsController assumes too much for instance variable '@petition'          
  
                                        IrresponsibleModule              
      Admin::PetitionTagsController has no descriptive comment          
  
  before_action :fetch_petition

  def show
    render 'admin/petitions/show'
  end

  def update
    if @petition.update(petition_params)
      redirect_to [:admin, @petition], notice: :petition_updated
    else
      render 'admin/petitions/show'
    end
  end

  private

  def fetch_petition
    @petition = Petition.find(params[:petition_id])
  end

  def petition_params
    params.require(:petition).permit(tags: [])
  end
end