Ruby Critic

Updated 2017-07-30 10:07:28 +0100

app/controllers / feedback_controller.rb

44 lines of codes

7 methods

4.1 complexity/method

9 churn

28.82 complexity

0 duplications

class FeedbackController < ApplicationController                                        InstanceVariableAssumption              
      FeedbackController assumes too much for instance variable '@feedback'          
  
                                        IrresponsibleModule              
      FeedbackController has no descriptive comment          
  
  before_action :build_feedback, only: [:new, :create]

  def new
    respond_to do |format|
      format.html
    end
  end

  def create
    if @feedback.save
      FeedbackEmailJob.perform_later(@feedback)
      redirect_to thanks_feedback_url
    else
      respond_to do |format|
        format.html { render :new }
      end
    end
  end

  def thanks
    respond_to do |format|
      format.html
    end
  end

  private

  def build_feedback
    @feedback = Feedback.new(params.key?(:feedback) ? feedback_params : {})
  end

  def feedback_params
    params.require(:feedback).permit(*feedback_attributes).merge(user_agent)
  end

  def feedback_attributes
    [:email, :petition_link_or_title, :comment]
  end

  def user_agent
    { user_agent: request.user_agent }
  end
end