Ruby Critic

Updated 2015-08-20 17:41:19 +0100

db/migrate / 20150820161504_insert_constituencies.rb

14 lines of codes

2 methods

5.1 complexity/method

1 churn

10.24 complexity

0 duplications

class InsertConstituencies < ActiveRecord::Migration                                        IrresponsibleModule              
      InsertConstituencies has no descriptive comment          
  
  def up                                        UtilityFunction              
      InsertConstituencies#up doesn't depend on instance state (maybe move it to another class?)          
  
    constituency_ids = ConstituencyPetitionJournal.distinct.pluck(:constituency_id)

    constituency_ids.each do |constituency_id|
      signature = Signature.where(constituency_id: constituency_id).order(nil).first
      signature.constituency if signature
    end
  end

  def down                                        UtilityFunction              
      InsertConstituencies#down doesn't depend on instance state (maybe move it to another class?)          
  
    Constituency.delete_all
  end
end