Ruby Critic

Updated 8 years ago
app/controllers/admin/archived / debate_outcomes_controller.rb

49 lines of codes
7 methods
3.5 complexity/method
17 churn
24.7 complexity
28 duplications
class Admin::Archived::DebateOutcomesController < Admin::AdminController                                        InstanceVariableAssumption              
      Admin::Archived::DebateOutcomesController assumes too much for instance variable '@debate_outcome'          
  
                                        InstanceVariableAssumption              
      Admin::Archived::DebateOutcomesController assumes too much for instance variable '@petition'          
  
                                        IrresponsibleModule              
      Admin::Archived::DebateOutcomesController has no descriptive comment          
  
 before_action :fetch_petition before_action :fetch_debate_outcome rescue_from ActiveRecord::RecordNotUnique do @debate_outcome = @petition.debate_outcome(true) and update end def show render 'admin/archived/petitions/show' end def update                                        DuplicateCode              
      Similar code found in 3 nodes              Locations:                  0                  1                  2                  
  
 if @debate_outcome.update(debate_outcome_params) if send_email_to_petitioners? ::Archived::EmailDebateOutcomesJob.run_later_tonight(petition: @petition) message = :email_sent_overnight else message = :debate_outcome_updated end redirect_to admin_archived_petition_url(@petition), notice: message else render 'admin/archived/petitions/show' end end private def fetch_petition @petition = ::Archived::Petition.debateable.find(params[:petition_id]) end def fetch_debate_outcome @debate_outcome = @petition.debate_outcome || @petition.build_debate_outcome end def debate_outcome_params params.require(:archived_debate_outcome).permit(*debate_outcome_attributes) end def debate_outcome_attributes %i[debated_on overview transcript_url video_url debate_pack_url debated commons_image] end def send_email_to_petitioners? params.key?(:save_and_email) end end