Ruby Critic

Updated 2018-03-29 09:12:40 +0100

app/controllers/admin / holidays_controller.rb

34 lines of codes

5 methods

3.5 complexity/method

1 churn

17.38 complexity

19 duplications

class Admin::HolidaysController < Admin::AdminController                                        InstanceVariableAssumption              
      Admin::HolidaysController assumes too much for instance variable '@holiday'          
  
                                        IrresponsibleModule              
      Admin::HolidaysController has no descriptive comment          
  
  before_action :require_sysadmin
  before_action :fetch_holiday

  def edit
    respond_to do |format|
      format.html
    end
  end

  def update                                        DuplicateCode              
      Similar code found in 2 nodes              Locations:                  0                  1                  
  
    if @holiday.update(holiday_params)
      redirect_to edit_admin_site_url, notice: :site_updated
    else
      respond_to do |format|
        format.html { render :edit }
      end
    end
  end

  private

  def fetch_holiday
    @holiday = Holiday.instance
  end

  def holiday_params
    params.require(:holiday).permit(*holiday_attributes)
  end

  def holiday_attributes
    %i[christmas_start christmas_end easter_start easter_end]
  end
end