Ruby Critic

Updated 2017-07-30 10:07:28 +0100
app/controllers/archived / petitions_controller.rb

89 lines of codes
14 methods
5.0 complexity/method
16 churn
70.53 complexity
0 duplications
require 'csv'

class Archived::PetitionsController < ApplicationController                                        InstanceVariableAssumption              
      Archived::PetitionsController assumes too much for instance variable '@parliament'          
  
                                        InstanceVariableAssumption              
      Archived::PetitionsController assumes too much for instance variable '@petition'          
  
                                        InstanceVariableAssumption              
      Archived::PetitionsController assumes too much for instance variable '@petitions'          
  
                                        IrresponsibleModule              
      Archived::PetitionsController has no descriptive comment          
  
  before_action :redirect_to_valid_state, only: [:index]
  before_action :fetch_parliament, only: [:index]
  before_action :fetch_petitions, only: [:index]
  before_action :fetch_petition, only: [:show]

  before_action :set_cors_headers, only: [:index, :show], if: :json_request?
  after_action :set_content_disposition, if: :csv_request?, only: [:index]

  helper_method :archived_petition_facets

  def index
    respond_to do |format|
      format.html                                        FeatureEnvy              
      Archived::PetitionsController#index refers to 'format' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
      format.json                                        FeatureEnvy              
      Archived::PetitionsController#index refers to 'format' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
      format.csv                                        FeatureEnvy              
      Archived::PetitionsController#index refers to 'format' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
    end
  end

  def show
    respond_to do |format|
      format.html                                        FeatureEnvy              
      Archived::PetitionsController#show refers to 'format' more than self (maybe move it to another class?)              Locations:                  0                  1                  
  
      format.json                                        FeatureEnvy              
      Archived::PetitionsController#show refers to 'format' more than self (maybe move it to another class?)              Locations:                  0                  1                  
  
    end
  end

  private

  def parliament_id
    params[:parliament].to_i
  end

  def petition_id
    params[:id].to_i
  end

  def fetch_parliament
    if params.key?(:parliament)
      @parliament = Parliament.archived.find(parliament_id)                                        DuplicateMethodCall              
      Archived::PetitionsController#fetch_parliament calls 'Parliament.archived' 2 times              Locations:                  0                  1                  
  
    else
      @parliament = Parliament.archived.first                                        DuplicateMethodCall              
      Archived::PetitionsController#fetch_parliament calls 'Parliament.archived' 2 times              Locations:                  0                  1                  
  
    end
  end

  def fetch_petitions
    @petitions = @parliament.petitions.search(params)
  end

  def fetch_petition
    @petition = Archived::Petition.visible.find(petition_id)
    @parliament = @petition.parliament

    unless @parliament.archived?
      redirect_to petition_url(petition_id)
    end
  end

  def csv_filename
    "#{@petitions.scope}-petitions-#{@parliament.period}.csv"
  end

  def redirect_to_valid_state
    if state_present? && !valid_state?
      redirect_to archived_petitions_url(search_params(state: :all))
    end
  end

  def state_present?
    params[:state].present?
  end

  def valid_state?
    archived_petition_facets.include?(params[:state].to_sym)
  end

  def search_params(overrides = {})
    params.permit(:page, :parliament, :q, :state).merge(overrides)
  end

  def archived_petition_facets                                        UtilityFunction              
      Archived::PetitionsController#archived_petition_facets doesn't depend on instance state (maybe move it to another class?)          
  
    I18n.t :archived, scope: :"petitions.facets", default: []
  end

  def set_content_disposition
    response.headers['Content-Disposition'] = "attachment; filename=#{csv_filename}"
  end
end