Ruby Critic

Updated 2015-09-04 15:21:08 +0100
app/models/constituency / api_client.rb

39 lines of codes
5 methods
3.6 complexity/method
2 churn
18.04 complexity
0 duplications
require 'faraday'
require 'postcode_sanitizer'

class Constituency < ActiveRecord::Base
  class ApiClient                                        IrresponsibleModule              
      Constituency::ApiClient has no descriptive comment          
  
    HOST = 'http://data.parliament.uk'
    ENDPOINT = '/membersdataplatform/services/mnis/Constituencies/%{postcode}/'
    TIMEOUT = 5

    def call(postcode)
      faraday.get(path(postcode)) do |request|
        request.options[:timeout] = TIMEOUT                                        DuplicateMethodCall              
      Constituency::ApiClient#call calls 'request.options' 2 times              Locations:                  0                  1                  
  
        request.options[:open_timeout] = TIMEOUT                                        DuplicateMethodCall              
      Constituency::ApiClient#call calls 'request.options' 2 times              Locations:                  0                  1                  
  
      end
    end

    private

    def faraday
      @faraday ||= Faraday.new(HOST) do |f|                                        UncommunicativeVariableName              
      Constituency::ApiClient#faraday has the variable name 'f'          
  
        f.response :follow_redirects                                        FeatureEnvy              
      Constituency::ApiClient#faraday refers to 'f' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
        f.response :raise_error                                        FeatureEnvy              
      Constituency::ApiClient#faraday refers to 'f' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
        f.adapter  :net_http_persistent                                        FeatureEnvy              
      Constituency::ApiClient#faraday refers to 'f' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
      end
    end

    def path(postcode)
      ENDPOINT % { postcode: escape_path(postcode) }
    end

    def escape_path(value)
      Rack::Utils.escape_path(sanitize(value))
    end

    def sanitize(value)                                        UtilityFunction              
      Constituency::ApiClient#sanitize doesn't depend on instance state (maybe move it to another class?)          
  
      PostcodeSanitizer.call(value)
    end
  end
end