Ruby Critic

Updated 2019-04-05 22:01:33 +0100
app/validators / email_validator.rb

24 lines of codes
3 methods
5.6 complexity/method
4 churn
16.8 complexity
0 duplications
class EmailValidator < ActiveModel::EachValidator                                        IrresponsibleModule              
      EmailValidator has no descriptive comment          
  
  EMAIL_REGEX = /\A[^@\s]+@[^@\s]+\.[^@\s]+\z/

  def validate_each(record, attribute, value)
    if value =~ EMAIL_REGEX
      email = parsed_email(value)
      record.errors.add attribute, :plus_address if plus_address?(email)                                        DuplicateMethodCall              
      EmailValidator#validate_each calls 'record.errors' 3 times              Locations:                  0                  1                  2                  
  
                                        FeatureEnvy              
      EmailValidator#validate_each refers to 'record' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
    else
      record.errors.add attribute, :invalid                                        DuplicateMethodCall              
      EmailValidator#validate_each calls 'record.errors' 3 times              Locations:                  0                  1                  2                  
  
                                        DuplicateMethodCall              
      EmailValidator#validate_each calls 'record.errors.add attribute, :invalid' 2 times              Locations:                  0                  1                  
  
                                        FeatureEnvy              
      EmailValidator#validate_each refers to 'record' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
    end
  rescue Mail::Field::ParseError
    record.errors.add attribute, :invalid                                        DuplicateMethodCall              
      EmailValidator#validate_each calls 'record.errors' 3 times              Locations:                  0                  1                  2                  
  
                                        DuplicateMethodCall              
      EmailValidator#validate_each calls 'record.errors.add attribute, :invalid' 2 times              Locations:                  0                  1                  
  
                                        FeatureEnvy              
      EmailValidator#validate_each refers to 'record' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  
  
  end

  def plus_address?(parsed_email)                                        UtilityFunction              
      EmailValidator#plus_address? doesn't depend on instance state (maybe move it to another class?)          
  
    unless Site.disable_plus_address_check?
      parsed_email.local.include? '+'
    end
  end

  def parsed_email(email)                                        UtilityFunction              
      EmailValidator#parsed_email doesn't depend on instance state (maybe move it to another class?)          
  
    Mail::Address.new(email)
  end
end