Ruby Critic

Updated 2015-06-10 11:14:45 +0100
db/migrate / 20150610091149_create_constituency_petition_journals.rb

13 lines of codes
1 methods
6.9 complexity/method
1 churn
6.87 complexity
30 duplications
class CreateConstituencyPetitionJournals < ActiveRecord::Migration                                        IrresponsibleModule              
      CreateConstituencyPetitionJournals has no descriptive comment          
  
  def change                                        TooManyStatements              
      CreateConstituencyPetitionJournals#change has approx 6 statements          
  
    create_table :constituency_petition_journals do |t|                                        DuplicateCode              
      Similar code found in 2 nodes              Locations:                  0                  1                  
  
                                        UncommunicativeVariableName              
      CreateConstituencyPetitionJournals#change has the variable name 't'          
  
      t.string :constituency_id, null: false                                        FeatureEnvy              
      CreateConstituencyPetitionJournals#change refers to 't' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  3                  
  
      t.references :petition, null: false                                        FeatureEnvy              
      CreateConstituencyPetitionJournals#change refers to 't' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  3                  
  
      t.integer :signature_count, default: 0, null: false                                        FeatureEnvy              
      CreateConstituencyPetitionJournals#change refers to 't' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  3                  
  

      t.timestamps null: false                                        FeatureEnvy              
      CreateConstituencyPetitionJournals#change refers to 't' more than self (maybe move it to another class?)              Locations:                  0                  1                  2                  3                  
  
    end

    add_index :constituency_petition_journals, [:petition_id, :constituency_id], unique: true, name: 'idx_constituency_petition_journal_uniqueness'
  end
end