RUBYCRITIC
RUBYCRITIC
require 'rails_helper'
RSpec.describe PetitionsController, type: :controller do
describe "GET /petitions/new" do
it "should assign a petition creator" do
get :new
expect(assigns[:new_petition]).not_to be_nil
end
it "is on stage 'petition'" do
get :new
expect(assigns[:new_petition].stage).to eq "petition";
end
it "fills in the action if given as query parameter 'q'" do
get :new, q: "my fancy new action"
expect(assigns[:new_petition].action).to eq("my fancy new action")
end
context "when parliament is dissolved" do -
before do
allow(Parliament).to receive(:dissolved?).and_return(true)
end
it "redirects to the home page" do
get :new
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
context "when parliament has not yet opened" do -
before do
allow(Parliament).to receive(:opened?).and_return(false)
end
it "redirects to the home page" do
get :new
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
end
describe "POST /petitions/new" do
let(:params) do
{
action: "Save the planet",
background: "Limit temperature rise at two degrees",
additional_details: "Global warming is upon us",
name: "John Mcenroe", email: "john@example.com",
postcode: "SE3 4LL", location_code: "GB",
uk_citizenship: "1"
}
end
let(:constituency) do
FactoryBot.create(:constituency, external_id: "54321", name: "North Creatorshire")
end
before do
allow(Constituency).to receive(:find_by_postcode).with("SE34LL").and_return(constituency)
end
context "valid post" do
let(:petition) { Petition.find_by_action("Save the planet") }
it "should successfully create a new petition and a signature" do - describe(POST /petitions/new)::context(valid post)::it#should successfully create a new petition and a signature has a flog score of 28
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params
end
expect(petition.creator).not_to be_nil
expect(response).to redirect_to("https://petition.parliament.uk/petitions/#{petition.id}/thank-you")
end
it "should successfully create a new petition and a signature even when email has white space either end" do -
- describe(POST /petitions/new)::context(valid post)::it#should successfully create a new petition and a signature even when email has white space either end has a flog score of 27
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(email: " john@example.com ")
end
expect(petition).not_to be_nil
expect(response).to redirect_to("https://petition.parliament.uk/petitions/#{petition.id}/thank-you")
end
it "should strip a petition action on petition creation" do -
- describe(POST /petitions/new)::context(valid post)::it#should strip a petition action on petition creation has a flog score of 27
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(action: " Save the planet")
end
expect(petition).not_to be_nil
expect(response).to redirect_to("https://petition.parliament.uk/petitions/#{petition.id}/thank-you")
end
it "should send gather sponsors email to petition's creator" do - describe(POST /petitions/new)::context(valid post)::it#should send gather sponsors email to petition's creator has a flog score of 28
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params
end
expect(last_email_sent).to deliver_to("john@example.com")
expect(last_email_sent).to deliver_from(%{"Petitions: UK Government and Parliament" <no-reply@petition.parliament.uk>})
expect(last_email_sent).to have_subject("Action required: Petition “Save the planet”")
end
it "should successfully point the signature at the petition" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params
end
expect(petition.creator.petition).to eq(petition)
end
it "should set user's ip address on signature" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params
end
expect(petition.creator.ip_address).to eq("0.0.0.0")
end
it "should not be able to set the state of a new petition" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(state: Petition::VALIDATED_STATE)
end
expect(petition.state).to eq(Petition::PENDING_STATE)
end
it "should not be able to set the state of a new signature" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(state: Signature::VALIDATED_STATE)
end
expect(petition.creator.state).to eq(Signature::PENDING_STATE)
end
it "should set notify_by_email to false on the creator signature" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(state: Signature::VALIDATED_STATE)
end
expect(petition.creator.notify_by_email).to be_falsey
end
it "sets the constituency_id on the creator signature, based on the postcode" do
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(state: Signature::VALIDATED_STATE)
end
expect(petition.creator.constituency_id).to eq("54321")
end
context "invalid post" do
it "should not create a new petition if no action is given" do - describe(POST /petitions/new)::context(valid post)::context(invalid post)::it#should not create a new petition if no action is given has a flog score of 40
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(action: "")
end
expect(petition).to be_nil
expect(assigns[:new_petition].errors[:action]).not_to be_blank
expect(response).to be_success
end
it "should not create a new petition if email is invalid" do -
- describe(POST /petitions/new)::context(valid post)::context(invalid post)::it#should not create a new petition if email is invalid has a flog score of 25
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(email: "not much of an email")
end
expect(petition).to be_nil
expect(response).to be_success
end
it "should not create a new petition if UK citizenship is not confirmed" do -
- describe(POST /petitions/new)::context(valid post)::context(invalid post)::it#should not create a new petition if UK citizenship is not confirmed has a flog score of 25
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(uk_citizenship: "0")
end
expect(petition).to be_nil
expect(response).to be_success
end
it "has stage of 'petition' if there is an error on action" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(action: "")
end
expect(assigns[:new_petition].stage).to eq "petition"
end
it "has stage of 'petition' if there is an error on background" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(background: "")
end
expect(assigns[:new_petition].stage).to eq "petition"
end
it "has stage of 'petition' if there is an error on additional_details" do - describe(POST /petitions/new)::context(valid post)::context(invalid post)::it#has stage of 'petition' if there is an error on additional_details has a flog score of 25
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(additional_details: "a" * 801)
end
expect(assigns[:new_petition].stage).to eq "petition"
end
it "has stage of 'creator' if there is an error on name" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(name: "")
end
expect(assigns[:new_petition].stage).to eq "creator"
end
it "has stage of 'creator' if there is an error on uk_citizenship" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(uk_citizenship: "0")
end
expect(assigns[:new_petition].stage).to eq "creator"
end
it "has stage of 'creator' if there is an error on postcode" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(postcode: "")
end
expect(assigns[:new_petition].stage).to eq "creator"
end
it "has stage of 'creator' if there is an error on location_code" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(location_code: "")
end
expect(assigns[:new_petition].stage).to eq "creator"
end
it "has stage of 'replay_email' if there are errors on email and we came from the 'replay_email' stage" do -
perform_enqueued_jobs do
post :create, stage: "replay_email", petition_creator: params.merge(email: "")
end
expect(assigns[:new_petition].stage).to eq "replay_email"
end
it "has stage of 'creator' if there are errors on email and we came from the 'creator' stage" do -
perform_enqueued_jobs do
post :create, stage: "creator", petition_creator: params.merge(email: "")
end
expect(assigns[:new_petition].stage).to eq "creator"
end
end
end
context "when parliament is dissolved" do
before do
allow(Parliament).to receive(:dissolved?).and_return(true)
end
it "redirects to the home page" do
post :create, petition: {}
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
context "when parliament has not yet opened" do
before do
allow(Parliament).to receive(:opened?).and_return(false)
end
it "redirects to the home page" do
post :create, petition: {}
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
end
describe "GET /petitions/:id" do
let(:petition) { double }
it "assigns the given petition" do - describe(GET /petitions/:id)::it#assigns the given petition has a flog score of 54
allow(petition).to receive(:stopped?).and_return(false)
allow(petition).to receive(:collecting_sponsors?).and_return(false)
allow(petition).to receive(:in_moderation?).and_return(false)
allow(petition).to receive(:moderated?).and_return(true)
allow(Petition).to receive_message_chain(:show, find: petition)
get :show, id: 1
expect(assigns(:petition)).to eq(petition)
end
it "does not allow hidden petitions to be shown" do
expect {
allow(Petition).to receive_message_chain(:visible, :find).and_raise ActiveRecord::RecordNotFound
get :show, id: 1
}.to raise_error(ActiveRecord::RecordNotFound)
end
it "does not allow stopped petitions to be shown" do - describe(GET /petitions/:id)::it#does not allow stopped petitions to be shown has a flog score of 52
allow(petition).to receive(:stopped?).and_return(true)
allow(petition).to receive(:collecting_sponsors?).and_return(false)
allow(petition).to receive(:in_moderation?).and_return(false)
allow(petition).to receive(:moderated?).and_return(false)
allow(Petition).to receive_message_chain(:show, find: petition)
get :show, id: 1
expect(response).to redirect_to "https://petition.parliament.uk/"
end
context "when the petition is archived" do
let!(:petition) { FactoryBot.create(:closed_petition, archived_at: 1.hour.ago) }
let!(:archived_petition) { FactoryBot.create(:archived_petition, id: petition.id, parliament: parliament) }
context "and the parliament is not archived" do
let!(:parliament) { FactoryBot.create(:parliament, archived_at: nil) }
it "assigns the given petition" do
get :show, id: petition.id
expect(assigns(:petition)).to eq(petition)
end
end
context "and the parliament is archived" do
let(:parliament) { FactoryBot.create(:parliament, archived_at: 1.hour.ago) }
it "redirects to the archived petition page" do
get :show, id: petition.id
expect(response).to redirect_to "https://petition.parliament.uk/archived/petitions/#{petition.id}"
end
end
end
end
describe "GET /petitions" do
context "when no state param is provided" do -
it "is successful" do
get :index
expect(response).to be_success
end
it "exposes a search scoped to the all facet" do
get :index
expect(assigns(:petitions).scope).to eq :all
end
end
context "when a state param is provided" do -
context "but it is not a public facet from the locale file" do
it "redirects to itself with state=all" do
get :index, state: "awaiting_monkey"
expect(response).to redirect_to "https://petition.parliament.uk/petitions?state=all"
end
it "preserves other params when it redirects" do
get :index, q: "what is clocks", state: "awaiting_monkey"
expect(response).to redirect_to "https://petition.parliament.uk/petitions?q=what+is+clocks&state=all"
end
end
context "and it is a public facet from the locale file" do
it "is successful" do
get :index, state: "open"
expect(response).to be_success
end
it "exposes a search scoped to the state param" do
get :index, state: "open"
expect(assigns(:petitions).scope).to eq :open
end
end
end
context "when parliament has not yet opened" do -
before do
allow(Parliament).to receive(:opened?).and_return(false)
end
it "redirects to the home page" do
get :index
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
end
describe "GET /petitions/check" do
it "is successful" do
get :check
expect(response).to be_success
end
context "when parliament is dissolved" do -
before do
allow(Parliament).to receive(:dissolved?).and_return(true)
end
it "redirects to the home page" do
get :check
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
context "when parliament has not yet opened" do -
before do
allow(Parliament).to receive(:opened?).and_return(false)
end
it "redirects to the home page" do
get :check
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
end
describe "GET /petitions/check_results" do
it "is successful" do
get :check_results, q: "action"
expect(response).to be_success
end
context "when parliament is dissolved" do
before do
allow(Parliament).to receive(:dissolved?).and_return(true)
end
it "redirects to the home page" do
get :check_results, q: "action"
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
context "when parliament has not yet opened" do
before do
allow(Parliament).to receive(:opened?).and_return(false)
end
it "redirects to the home page" do
get :check_results, q: "action"
expect(response).to redirect_to("https://petition.parliament.uk/")
end
end
end
end