Ruby Critic

Updated 2017-09-18 09:40:34 +0100
spec/jobs / backfill_constituencies_job_spec.rb

107 lines of codes
0 methods
N/A complexity/method
1 churn
274.25 complexity
78 duplications
require 'rails_helper'

RSpec.describe BackfillConstituenciesJob, type: :job do
  context "when the constituency_id column is nil" do
    let(:signature) { FactoryBot.create(:validated_signature, constituency_id: nil) }

    it "updates the constituency_id column" do
      expect {
        described_class.perform_now
      }.to change {
        signature.reload.constituency_id
      }.from(nil).to("3415")
    end
  end

  context "when the constituency_id column is not nil" do
    let(:signature) { FactoryBot.create(:validated_signature, constituency_id: "1234") }

    it "skips updating the constituency_id" do
      expect {
        described_class.perform_now
      }.not_to change {
        signature.reload.constituency_id
      }
    end
  end

  context "when limited in scope by id" do
    let!(:signature_1) { FactoryBot.create(:validated_signature, constituency_id: nil) }
    let!(:signature_2) { FactoryBot.create(:validated_signature, constituency_id: nil) }

    it "updates those in scope" do                                        HighComplexity              
      context(when limited in scope by id)::it#updates those in scope has a flog score of 25          
  
      expect {
        described_class.perform_now(id: signature_1.id)
      }.to change {
        signature_2.reload.constituency_id
      }.from(nil).to("3415")
    end

    it "doesn't update those out of scope" do
      expect {
        described_class.perform_now(id: signature_1.id)
      }.not_to change {
        signature_1.reload.constituency_id
      }
    end
  end

  context "when limited in scope by date" do
    let!(:signature_1) { FactoryBot.create(:validated_signature, constituency_id: nil, validated_at: 2.weeks.ago) }
    let!(:signature_2) { FactoryBot.create(:validated_signature, constituency_id: nil, validated_at: 1.day.ago) }

    it "updates those in scope" do                                        HighComplexity              
      context(when limited in scope by date)::it#updates those in scope has a flog score of 25          
  
      expect {
        described_class.perform_now(since: 1.week.ago)
      }.to change {
        signature_2.reload.constituency_id
      }.from(nil).to("3415")
    end

    it "doesn't update those out of scope" do                                        DuplicateCode              
      Similar code found in 3 nodes              Locations:                  0                  1                  2                  
  
      expect {
        described_class.perform_now(since: 1.week.ago)
      }.not_to change {
        signature_1.reload.constituency_id
      }
    end
  end

  context "when limited in scope by id and date" do
    let!(:signature_1) { FactoryBot.create(:validated_signature, constituency_id: nil, validated_at: 2.weeks.ago) }
    let!(:signature_2) { FactoryBot.create(:validated_signature, constituency_id: nil, validated_at: 1.day.ago) }
    let!(:signature_3) { FactoryBot.create(:validated_signature, constituency_id: nil, validated_at: 1.day.ago) }

    it "updates those in scope" do                                        HighComplexity              
      context(when limited in scope by id and date)::it#updates those in scope has a flog score of 29          
  
      expect {
        described_class.perform_now(id: signature_2.id, since: 1.week.ago)
      }.to change {
        signature_3.reload.constituency_id
      }.from(nil).to("3415")
    end

    it "doesn't update those out of scope" do                                        DuplicateCode              
      Similar code found in 3 nodes              Locations:                  0                  1                  2                  
  
      expect {
        described_class.perform_now(since: 1.week.ago)
      }.not_to change {
        signature_1.reload.constituency_id
      }
    end

    it "doesn't update those out of scope by date" do                                        DuplicateCode              
      Similar code found in 2 nodes              Locations:                  0                  1                  
  
      expect {
        described_class.perform_now(id: signature_2.id, since: 1.week.ago)
      }.not_to change {
        signature_1.reload.constituency_id
      }
    end

    it "doesn't update those out of scope by id" do                                        DuplicateCode              
      Similar code found in 2 nodes              Locations:                  0                  1                  
  
      expect {
        described_class.perform_now(id: signature_2.id, since: 1.week.ago)
      }.not_to change {
        signature_2.reload.constituency_id
      }
    end
  end
end