RUBYCRITIC
RUBYCRITIC
require 'rails_helper'
RSpec.describe Constituency, type: :model do
it "has a valid factory" do
expect(FactoryBot.build(:constituency)).to be_valid
end
describe "schema" do - describe#schema has a flog score of 88
it { is_expected.to have_db_column(:name).of_type(:string).with_options(null: false, limit: 100) }
it { is_expected.to have_db_column(:slug).of_type(:string).with_options(null: false, limit: 100) }
it { is_expected.to have_db_column(:external_id).of_type(:string).with_options(null: false, limit: 30) }
it { is_expected.to have_db_column(:ons_code).of_type(:string).with_options(null: false, limit: 10) }
it { is_expected.to have_db_column(:mp_id).of_type(:string).with_options(null: true, limit: 30) }
it { is_expected.to have_db_column(:mp_name).of_type(:string).with_options(null: true, limit: 100) }
it { is_expected.to have_db_column(:mp_date).of_type(:date).with_options(null: true) }
it { is_expected.to have_db_column(:example_postcode).of_type(:string).with_options(null: true, limit: 30) }
end
describe "associations" do -
it { is_expected.to have_many(:signatures) }
it { is_expected.to have_many(:petitions).through(:signatures) }
end
describe "indexes" do
it { is_expected.to have_db_index([:slug]).unique }
it { is_expected.to have_db_index([:external_id]).unique }
end
describe "validations" do - describe#validations has a flog score of 115
subject { FactoryBot.build(:constituency) }
it { is_expected.to validate_presence_of(:name) }
it { is_expected.to validate_length_of(:name).is_at_most(100) }
it { is_expected.to validate_presence_of(:external_id) }
it { is_expected.to validate_length_of(:external_id).is_at_most(30) }
it { is_expected.to validate_presence_of(:ons_code) }
it { is_expected.not_to allow_value("E1").for(:ons_code) }
it { is_expected.not_to allow_value("J00000001").for(:ons_code) }
%w[E W S N].each do |country|
it { is_expected.to allow_value("%s%08d" % [country, 1]).for(:ons_code) }
end
it { is_expected.not_to validate_presence_of(:mp_id) }
it { is_expected.to validate_length_of(:mp_id).is_at_most(30) }
it { is_expected.not_to validate_presence_of(:mp_name) }
it { is_expected.to validate_length_of(:mp_name).is_at_most(100) }
it { is_expected.not_to validate_presence_of(:mp_date) }
it { is_expected.to validate_presence_of(:example_postcode) }
it "should not allow an :example_postcode that doesn't belong to the constituency" do
constituency = FactoryBot.create(:constituency, :romford)
stub_api_request_for("CV66HN").to_return(api_response(:ok, "coventry_north_east"))
expect {
constituency.update!(example_postcode: "CV66HN")
}.to raise_error(ActiveRecord::RecordInvalid)
end
end
describe "callbacks" do
describe "slug" do
context "when creating a constituency" do
let!(:constituency) { FactoryBot.create(:constituency, name: "Coventry North East") }
it "is generated from the name" do
expect(constituency.slug).to eq("coventry-north-east")
end
end
context "when updated a constituency" do
let!(:constituency) { FactoryBot.create(:constituency, name: "Coventry North East") }
before do
constituency.update!(name: "Coventry North")
end
it "is regenerated from the name" do
expect(constituency.slug).to eq("coventry-north")
end
end
end
describe "example_postcode" do
context "when creating a constituency" do
let(:constituency) do
FactoryBot.create(:constituency, :romford, example_postcode: example_postcode)
end
context "and the example_postcode is nil" do
let(:example_postcode) { nil }
it "is looked up from the ONS code" do
expect(constituency.example_postcode).to eq("RM53FZ")
end
end
context "and the example_postcode is specified" do
let(:example_postcode) { "RM70HD" }
it "respects the specified value" do
expect(constituency.example_postcode).to eq("RM70HD")
end
end
end
context "when updating a constituency" do
let(:constituency) do
FactoryBot.create(:constituency, :romford, example_postcode: "RM53FA")
end
context "and the example_postcode is nil" do
before do
stub_api_request_for("RM53FZ").to_return(api_response(:ok, "romford"))
constituency.update!(example_postcode: nil)
end
it "is looked up from the ONS code" do
expect(constituency.example_postcode).to eq("RM53FZ")
end
end
context "and the example_postcode is specified" do
before do
stub_api_request_for("RM70HD").to_return(api_response(:ok, "romford"))
constituency.update!(example_postcode: "RM70HD")
end
it "respects the specified value" do
expect(constituency.example_postcode).to eq("RM70HD")
end
end
end
end
end
describe ".find_by_postcode" do
context "when the constituency doesn't exist in the database" do
before do
stub_api_request_for("N11TY").to_return(api_response(:ok, "single"))
end
it "saves the constituency to the database" do
constituency = Constituency.find_by_postcode("N11TY")
expect(constituency.persisted?).to be_truthy
end
end
context "when the constituency already exists in the database" do
let!(:existing_constituency) do
FactoryBot.create(:constituency, {
name: "Islington South and Finsbury", external_id: "3550", ons_code: "E14000764",
mp_id: "1536", mp_name: "Emily Thornberry MP", mp_date: "2015-05-07T00:00:00"
})
end
before do
stub_api_request_for("N11TY").to_return(api_response(:ok, "single"))
end
it "returns the existing record" do
constituency = Constituency.find_by_postcode("N11TY")
expect(constituency).to eq(existing_constituency)
end
end
context "when the API returns no results" do
before do
stub_api_request_for("N11TY").to_return(api_response(:not_acceptable))
end
it "returns nil" do
constituency = Constituency.find_by_postcode("N11TY")
expect(constituency).to be_nil
end
end
context "when the API returns updated results" do
let(:constituency) do
Constituency.find_by_postcode('OL90LS')
end
before do -
FactoryBot.create(:constituency, {
name: "Oldham West and Royton", external_id: "3671", ons_code: "E14000871",
mp_id: "454", mp_name: "Mr Michael Meacher", mp_date: "2015-05-07T00:00:00"
})
stub_api_request_for("OL90LS").to_return(api_response(:ok, "updated"))
end
it "updates the existing constituency" do
expect(constituency.mp_name).to eq("Jim McMahon MP")
end
it "persists the changes to the database" do
expect(constituency.reload.mp_name).to eq("Jim McMahon MP")
end
end
context "when the MP has passed away" do
let(:constituency) do
Constituency.find_by_postcode('S48AA')
end
before do -
FactoryBot.create(:constituency, {
name: "Sheffield, Brightside and Hillsborough", external_id: "3724", ons_code: "E14000921",
mp_id: "4477", mp_name: "Harry Harpham", mp_date: "2015-05-07T00:00:00"
})
stub_api_request_for("S48AA").to_return(api_response(:ok, "vacant"))
end
it "updates the existing constituency" do
expect(constituency.mp_name).to eq(nil)
end
it "persists the changes to the database" do
expect(constituency.reload.mp_name).to eq(nil)
end
end
end
describe ".refresh!" do
context "when Parliament has dissolved" do
let!(:constituency_1) do
FactoryBot.create(:constituency, :coventry_north_east)
end
let!(:constituency_2) do
FactoryBot.create(:constituency, :sheffield_brightside_and_hillsborough)
end
before do
stub_api_request_for("CV21PH").to_return(api_response(:ok, "coventry_north_east"))
stub_api_request_for("S61AR").to_return(api_response(:ok, "sheffield_brightside_and_hillsborough"))
end
it "updates the existing constituencies" do - describe(.refresh!)::context(when Parliament has dissolved)::it#updates the existing constituencies has a flog score of 26
expect {
Constituency.refresh!
}.to change { -
[
constituency_1.reload.mp_name,
constituency_2.reload.mp_name
]
}.from(["Colleen Fletcher MP", "Gill Furniss"]).to([nil, nil])
end
end
end
describe "#sitting_mp?" do
context "when the MP details are available" do -
let(:constituency) { FactoryBot.build(:constituency, mp_id: "4477", mp_name: "Harry Harpham") }
it "returns true" do
expect(constituency.sitting_mp?).to be true
end
end
context "when the MP details are not available" do -
let(:constituency) { FactoryBot.build(:constituency, mp_id: nil, mp_name: nil) }
it "returns false" do
expect(constituency.sitting_mp?).to be false
end
end
end
describe "#mp_url" do
let(:constituency) { FactoryBot.build(:constituency, mp_id: "2564", mp_name: "The Rt. Hon. Duncan Short MP") }
it "generates a valid link to the MP on the parliament.uk website" do
expect(constituency.mp_url).to eq <<-URL.strip
http://www.parliament.uk/biographies/commons/the-rt-hon-duncan-short-mp/2564
URL
end
end
describe "#refresh!" do
context "when Parliament has dissolved" do
let!(:constituency) do
FactoryBot.create(:constituency, :coventry_north_east)
end
before do
stub_api_request_for("CV21PH").to_return(api_response(:ok, "coventry_north_east"))
end
it "updates the existing constituency" do
expect {
constituency.refresh!
}.to change {
constituency.reload.mp_name
}.from("Colleen Fletcher MP").to(nil)
end
end
context "when there is no example postcode" do
let!(:constituency) do
FactoryBot.create(:constituency, :coventry_north_east)
end
before do
allow(constituency).to receive(:example_postcode).and_return(nil)
allow(constituency).to receive(:example_postcode?).and_return(false)
end
it "doesn't update the constituency" do
expect {
constituency.refresh!
}.not_to change {
constituency.reload.mp_name
}
end
end
context "when the API returns no results" do -
let!(:constituency) do
FactoryBot.create(:constituency, :coventry_north_east)
end
before do
stub_api_request_for("CV21PH").to_return(api_response(:ok, "no_results"))
end
it "raises a RuntimeError" do
expect { constituency.refresh! }.to raise_error(RuntimeError, /empty results/)
end
end
context "when a postcode lookup mismatch occurs" do -
let!(:constituency) do
FactoryBot.create(:constituency, :coventry_north_east)
end
before do
stub_api_request_for("CV21PH").to_return(api_response(:ok, "sheffield_brightside_and_hillsborough"))
end
it "raises a RuntimeError" do
expect { constituency.refresh! }.to raise_error(RuntimeError, /mismatched constituencies/)
end
end
end
end