RUBYCRITIC
RUBYCRITIC
require 'rails_helper'
RSpec.describe CountryPetitionJournal, type: :model do
before do
FactoryBot.create(:location, code: "GB", name: "United Kingdom")
end
let(:location) { Location.find_by!(code: "GB") }
let(:location_code) { "GB" }
it "has a valid factory" do
expect(FactoryBot.build(:country_petition_journal)).to be_valid
end
describe "defaults" do
it "has 0 for initial signature_count" do
expect(subject.signature_count).to eq 0
end
end
describe "indexes" do
it { is_expected.to have_db_index([:petition_id, :location_code]).unique }
end
describe "validations" do -
it { is_expected.to validate_presence_of(:location) }
it { is_expected.to validate_presence_of(:petition) }
it { is_expected.to validate_presence_of(:signature_count) }
end
describe ".for" do
let(:petition) { FactoryBot.create(:petition) }
context "when there is a journal for the requested petition and country" do -
let!(:existing_record) { FactoryBot.create(:country_petition_journal, petition: petition, location: location, signature_count: 30) }
it "doesn't create a new record" do
expect {
described_class.for(petition, location_code)
}.not_to change(described_class, :count)
end
it "fetches the instance from the DB" do
fetched = described_class.for(petition, location_code)
expect(fetched).to eq(existing_record)
end
end
context "when there is no journal for the requested petition and country" do -
let!(:journal) { described_class.for(petition, location_code) }
it "returns a newly created instance" do
expect(journal).to be_an_instance_of(described_class)
end
it "persists the new instance in the DB" do
expect(journal).to be_persisted
end
it "sets the petition of the new instance to the supplied petition" do
expect(journal.petition).to eq(petition)
end
it "sets the country of the new instance to the supplied country" do
expect(journal.location_code).to eq(location_code)
end
it "has 0 for a signature count" do
expect(journal.signature_count).to eq(0)
end
end
end
describe ".invalidate_signature_for" do
let!(:petition) { FactoryBot.create(:open_petition) }
let!(:journal) { FactoryBot.create(:country_petition_journal, petition: petition, location: location, signature_count: signature_count) }
let(:signature_count) { 1 }
context "when the supplied signature is valid" do
let(:signature) { FactoryBot.build(:invalidated_signature, petition: petition, location_code: "GB") }
let(:now) { 1.hour.from_now.change(usec: 0) }
it "decrements the signature_count by 1" do -
expect {
described_class.invalidate_signature_for(signature)
}.to change { journal.reload.signature_count }.by(-1)
end
it "updates the updated_at timestamp" do -
- describe(.invalidate_signature_for)::context(when the supplied signature is valid)::it#updates the updated_at timestamp has a flog score of 25
expect {
described_class.invalidate_signature_for(signature, now)
}.to change { journal.reload.updated_at }.to(now)
end
end
context "when the supplied signature is nil" do -
let(:signature) { nil }
it "does nothing" do
expect {
described_class.invalidate_signature_for(signature)
}.not_to change { journal.reload.signature_count }
end
end
context "when the supplied signature has no petition" do
let(:signature) { FactoryBot.build(:invalidated_signature, petition: nil, location_code: "GB") }
it "does nothing" do
expect {
described_class.invalidate_signature_for(signature)
}.not_to change { journal.reload.signature_count }
end
end
context "when the supplied signature has no country" do -
let(:signature) { FactoryBot.build(:invalidated_signature, petition: petition, location_code: nil) }
it "does nothing" do
expect {
described_class.invalidate_signature_for(signature)
}.not_to change { journal.reload.signature_count }
end
end
context "when the supplied signature is not validated" do
let(:signature) { FactoryBot.build(:pending_signature, petition: petition, location_code: "GB") }
it "does nothing" do
expect {
described_class.invalidate_signature_for(signature)
}.not_to change { journal.reload.signature_count }
end
end
context "when the signature count is already zero" do
let(:signature) { FactoryBot.build(:invalidated_signature, petition: petition, location_code: "GB") }
let(:signature_count) { 0 }
it "does nothing" do
expect {
described_class.invalidate_signature_for(signature)
}.not_to change { journal.reload.signature_count }
end
end
context "when no journal exists" do
let(:signature) { FactoryBot.build(:invalidated_signature, petition: petition, location_code: "GB") }
before do
described_class.delete_all
end
it "creates a new journal" do
expect {
described_class.invalidate_signature_for(signature)
}.to change(described_class, :count).by(1)
end
end
end
describe ".increment_signature_counts_for" do
let!(:location_1) { FactoryBot.create(:location, code: "AA", name: "Country 1") }
let!(:location_2) { FactoryBot.create(:location, code: "ZZ", name: "Country 2") }
let!(:location_code_1) { location_1.code }
let!(:location_code_2) { location_2.code }
let!(:petition) { FactoryBot.create(:petition, creator_attributes: {location_code: location_code_1}) }
let(:journal_1) { described_class.for(petition, location_code_1) }
let(:journal_2) { described_class.for(petition, location_code_2) }
before do
FactoryBot.create(:validated_signature, petition: petition, location_code: "AA")
FactoryBot.create(:validated_signature, petition: petition, location_code: "ZZ")
petition.update_signature_count!
described_class.reset_signature_counts_for(petition)
end
it "increments all of the journals" do - describe(.increment_signature_counts_for)::it#increments all of the journals has a flog score of 61
expect(journal_1.signature_count).to eq(2)
expect(journal_2.signature_count).to eq(1)
FactoryBot.create(:validated_signature, petition: petition, location_code: "AA")
FactoryBot.create(:validated_signature, petition: petition, location_code: "ZZ")
last_signed_at = petition.last_signed_at
petition.increment_signature_count!
described_class.increment_signature_counts_for(petition, last_signed_at)
expect(journal_1.reload.signature_count).to eq(3)
expect(journal_2.reload.signature_count).to eq(2)
end
end
describe ".reset_signature_counts_for" do - describe#.reset_signature_counts_for has a flog score of 58
let!(:location_1) { FactoryBot.create(:location, code: "AA", name: "Country 1") }
let!(:location_2) { FactoryBot.create(:location, code: "ZZ", name: "Country 2") }
let!(:location_code_1) { location_1.code }
let!(:location_code_2) { location_2.code }
let!(:petition_1) { FactoryBot.create(:petition, creator_attributes: {location_code: location_code_1}) }
let!(:petition_2) { FactoryBot.create(:petition, creator_attributes: {location_code: location_code_1}) }
before do -
# We do this so last_signed_at is not nil
petition_1.update_signature_count!
petition_2.update_signature_count!
described_class.for(petition_1, location_code_1).update_columns(signature_count: 20, last_signed_at: 5.minutes.ago)
described_class.for(petition_1, location_code_2).update_columns(signature_count: 10, last_signed_at: nil)
described_class.for(petition_2, location_code_1).update_columns(signature_count: 1, last_signed_at: 5.minutes.ago)
described_class.for(petition_2, location_code_2).update_columns(signature_count: 1, last_signed_at: nil)
end
context 'when there are no signatures' do -
it 'resets all the counts to 0 or 1 for the creator' do - describe(.reset_signature_counts_for)::context(when there are no signatures)::it#resets all the counts to 0 or 1 for the creator has a flog score of 75
described_class.reset_signature_counts_for(petition_1)
described_class.reset_signature_counts_for(petition_2)
expect(described_class.for(petition_1, location_code_1).signature_count).to eq 1
expect(described_class.for(petition_1, location_code_2).signature_count).to eq 0
expect(described_class.for(petition_2, location_code_1).signature_count).to eq 1
expect(described_class.for(petition_2, location_code_2).signature_count).to eq 0
end
end
context 'when there are signatures' do - describe(.reset_signature_counts_for)::context#when there are signatures has a flog score of 58
before do -
4.times { FactoryBot.create(:validated_signature, petition: petition_1, location_code: location_code_1, validated_at: 1.minute.ago) }
2.times { FactoryBot.create(:pending_signature, petition: petition_1, location_code: location_code_1) }
3.times { FactoryBot.create(:validated_signature, petition: petition_1, location_code: location_code_2, validated_at: 1.minute.ago) }
2.times { FactoryBot.create(:validated_signature, petition: petition_2, location_code: location_code_1, validated_at: 1.minute.ago) }
5.times { FactoryBot.create(:pending_signature, petition: petition_2, location_code: location_code_2) }
end
it 'resets the counts to that of the validated signatures for the petition and country' do - describe(.reset_signature_counts_for)::context(when there are signatures)::it#resets the counts to that of the validated signatures for the petition and country has a flog score of 80
described_class.reset_signature_counts_for(petition_1)
described_class.reset_signature_counts_for(petition_2)
expect(described_class.for(petition_1, location_code_1).signature_count).to eq 5 # +1 for the creator
expect(described_class.for(petition_1, location_code_2).signature_count).to eq 3
expect(described_class.for(petition_2, location_code_1).signature_count).to eq 3 # +1 for the creator
expect(described_class.for(petition_2, location_code_2).signature_count).to eq 0
end
it 'does not attempt to journal signatures without location codes' do - describe(.reset_signature_counts_for)::context(when there are signatures)::it#does not attempt to journal signatures without location codes has a flog score of 54
# The schema allows for nil countries, but our validations don't - update_column lets us get around that (!)
FactoryBot.create(:validated_signature, petition: petition_1, location_code: 'About to disappear').update_column(:location_code, nil)
FactoryBot.create(:validated_signature, petition: petition_1, location_code: 'About to disappear').update_column(:location_code, '')
expect {
described_class.reset_signature_counts_for(petition_1)
described_class.reset_signature_counts_for(petition_2)
}.not_to raise_error
expect(described_class.find_by(petition: petition_1, location_code: nil)).to be_nil
expect(described_class.find_by(petition: petition_1, location_code: '')).to be_nil
end
end
end
end