RUBYCRITIC
RUBYCRITIC
require 'rails_helper'
RSpec.describe 'Requests for pages when we do not support the format on that page', type: :request, show_exceptions: true do
let(:petition) { FactoryBot.create :open_petition }
before do
FactoryBot.create(:parliament, :archived)
end
shared_examples 'a route that only supports html formats' do |headers_only: false| - shared_examples#a route that only supports html formats has a flog score of 43
unless headers_only
it 'does not support json via extension' do
get url + '.json', params
expect(response.status).to eq 406
end
it 'does not support xml via extension' do
get url + '.xml', params
expect(response.status).to eq 406
end
end
it 'supports html' do -
- shared_examples(a route that only supports html formats)::it#supports html has a flog score of 25
get url, params
expect(response.status).to eq 200
expect(response.content_type).to eq :html
end
it 'does not support json via accepts header' do -
get url, params, {'Accept' => 'application/json'}
expect(response.status).to eq 406
end
it 'does not support xml via accepts header' do -
get url, params, {'Accept' => 'application/xml'}
expect(response.status).to eq 406
end
end
shared_examples 'a route that supports html and json formats' do |headers_only: false| - shared_examples#a route that supports html and json formats has a flog score of 53
unless headers_only
it 'supports json via extension' do
get url + '.json', params
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'does not support xml via extension' do
get url + '.xml', params
expect(response.status).to eq 406
end
end
it 'supports html' do -
- shared_examples(a route that supports html and json formats)::it#supports html has a flog score of 25
get url, params
expect(response.status).to eq 200
expect(response.content_type).to eq :html
end
it 'supports json via accepts header' do -
- shared_examples(a route that supports html and json formats)::it#supports json via accepts header has a flog score of 25
get url, params, {'Accept' => 'application/json'}
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'does not support xml via accepts header' do -
get url, params, {'Accept' => 'application/xml'}
expect(response.status).to eq 406
end
end
shared_examples 'a route that supports html, json and csv formats' do |headers_only: false| - shared_examples#a route that supports html, json and csv formats has a flog score of 84
unless headers_only
it 'supports json via extension' do
get url + '.json', params
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'supports csv via extension' do
get url + '.csv', params
expect(response.status).to eq 200
expect(response.content_type).to eq :csv
end
it 'does not support xml via extension' do
get url + '.xml', params
expect(response.status).to eq 406
end
end
it 'supports html' do -
- shared_examples(a route that supports html, json and csv formats)::it#supports html has a flog score of 25
get url, params
expect(response.status).to eq 200
expect(response.content_type).to eq :html
end
it 'supports json via accepts header' do -
- shared_examples(a route that supports html, json and csv formats)::it#supports json via accepts header has a flog score of 25
get url, params, {'Accept' => 'application/json'}
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'supports csv via accepts header' do -
- shared_examples(a route that supports html, json and csv formats)::it#supports csv via accepts header has a flog score of 25
get url, params, {'Accept' => 'text/csv'}
expect(response.status).to eq 200
expect(response.content_type).to eq :csv
end
it 'does not support xml via accepts header' do -
get url, params, {'Accept' => 'application/xml'}
expect(response.status).to eq 406
end
end
shared_examples 'a POST route where failure only supports html formats' do
around do |example|
begin
ActionController::Base.allow_forgery_protection = false
example.call
ensure
ActionController::Base.allow_forgery_protection = true
end
end
it 'does not support json via extension' do
post url + '.json', params
expect(response.status).to eq 406
end
it 'does not support xml via extension' do
post url + '.xml', params
expect(response.status).to eq 406
end
it 'supports html' do -
- shared_examples(a POST route where failure only supports html formats)::it#supports html has a flog score of 25
post url, params
expect(response.status).to eq 200
expect(response.content_type).to eq :html
end
it 'does not support json via accepts header' do -
post url, params, {'Accept' => 'application/json'}
expect(response.status).to eq 406
end
it 'does not support xml via accepts header' do -
post url, params, {'Accept' => 'application/xml'}
expect(response.status).to eq 406
end
end
context 'the root url' do
let(:url) { '/' }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats', headers_only: true
end
simple_html_only_urls = [
'help', 'privacy', 'feedback', 'feedback/thanks', 'petitions/local',
'petitions/check', 'petitions/check_results', 'petitions/new'
]
simple_html_only_urls.each do |simple_url|
context "the #{simple_url} url" do
let(:url) { "/#{simple_url}" }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
end
context "the petitions url" do
let(:url) { "/petitions" }
let(:params) { {} }
it_behaves_like 'a route that supports html, json and csv formats'
end
context "the archived/petitions url" do
let(:url) { "/archived/petitions" }
let(:params) { {} }
it_behaves_like 'a route that supports html and json formats'
end
context 'the petitions/local results url' do -
let(:url) { "/petitions/local/#{constituency.slug}" }
let(:constituency) { FactoryBot.create(:constituency) }
let(:params) { {} }
it_behaves_like 'a route that supports html, json and csv formats'
end
context 'the petitions/local/all results url' do -
let(:url) { "/petitions/local/#{constituency.slug}/all" }
let(:constituency) { FactoryBot.create(:constituency) }
let(:params) { {} }
it_behaves_like 'a route that supports html, json and csv formats'
end
context 'the petitions show url' do -
let(:url) { "/petitions/#{petition.id}" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:params) { {} }
it_behaves_like 'a route that supports html and json formats'
end
context 'the petitions/thank-you url' do -
let(:url) { "/petitions/#{petition.id}/thank-you" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/gathering-support url' do -
let(:url) { "/petitions/#{petition.id}/gathering-support" }
let(:petition) { FactoryBot.create(:validated_petition) }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/moderation-info url' do -
let(:url) { "/petitions/#{petition.id}/moderation-info" }
let(:petition) { FactoryBot.create(:sponsored_petition) }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/sponsors/new url' do -
let(:url) { "/petitions/#{petition.id}/sponsors/new" }
let(:petition) { FactoryBot.create(:pending_petition) }
let(:params) {
{
'token' => petition.sponsor_token
}
}
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/sponsors/thank-you url' do -
let(:url) { "/petitions/#{petition.id}/sponsors/thank-you" }
let(:petition) { FactoryBot.create(:pending_petition) }
let(:params) {
{
'token' => petition.sponsor_token
}
}
it_behaves_like 'a route that only supports html formats'
end
context 'the sponsors/sponsored url' do
let(:url) { "/sponsors/#{signature.id}/sponsored" }
let(:petition) { FactoryBot.create(:pending_petition) }
let(:signature) { FactoryBot.create(:sponsor, :pending, petition: petition) }
let(:params) { {} }
before do
get "/sponsors/#{signature.id}/verify?token=#{signature.perishable_token}"
end
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/signatures/new url' do -
let(:url) { "/petitions/#{petition.id}/signatures/new" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
context 'the petitions/signatures/thank-you url' do -
let(:url) { "/petitions/#{petition.id}/signatures/thank-you" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:params) { {} }
it_behaves_like 'a route that only supports html formats'
end
context 'the signatures/signed url' do
let(:url) { "/signatures/#{signature.id}/signed" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:signature) { FactoryBot.create(:pending_signature, petition: petition) }
let(:params) { {} }
before do
get "/signatures/#{signature.id}/verify?token=#{signature.perishable_token}"
end
it_behaves_like 'a route that only supports html formats'
end
# NOTE: we don't have a context for the signatures/verify url
# because current implementation is that it *always* redirects, so no
# content negotiation is required
context 'the signatures/unsubscribe url' do
let(:url) { "/signatures/#{signature.id}/unsubscribe" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:signature) { FactoryBot.create(:validated_signature, petition: petition) }
let(:params) {
{
'token' => signature.unsubscribe_token
}
}
it_behaves_like 'a route that only supports html formats'
end
context 'the archived/petitions show url' do -
let(:url) { "/archived/petitions/#{petition.id}" }
let(:petition) { FactoryBot.create(:archived_petition) }
let(:params) { {} }
it_behaves_like 'a route that supports html and json formats'
end
context 'the browserconfig url' do -
let(:url) { '/browserconfig' }
let(:params) { {} }
it 'does not support json via extension' do
get url + '.json', params
expect(response.status).to eq 404
end
it 'supports xml via extension' do - context(the browserconfig url)::it#supports xml via extension has a flog score of 26
get url + '.xml', params
expect(response.status).to eq 200
expect(response.content_type).to eq :xml
end
it 'does not response without an extension' do
get url, params
expect(response.status).to eq 404
end
end
context 'the manifest url' do -
let(:url) { '/manifest' }
let(:params) { {} }
it 'does not support xml via extension' do
get url + '.xml', params
expect(response.status).to eq 404
end
it 'supports xml via extension' do - context(the manifest url)::it#supports xml via extension has a flog score of 26
get url + '.json', params
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'does not response without an extension' do
get url, params
expect(response.status).to eq 404
end
end
# NOTE: we only check failed posts for petitions/new, signatures/new, and
# feedback because the success case will redirect and no content-negotiation
# is required.
context 'a failed post to petitions/new' do
let(:url) { '/petitions/new' }
let(:params) {
{
'stage' => 'replay-email',
'move' => 'next',
'petition' => {
'background' => 'Limit temperature rise at two degrees',
'additional_details' => 'Global warming is upon us',
'creator' => {
'name' => 'John Mcenroe', 'email' => 'john@example.com',
'postcode' => 'SE3 4LL', 'location_code' => 'GB',
'uk_citizenship' => '1'
}
}
}
}
it_behaves_like 'a POST route where failure only supports html formats'
end
context 'a failed post to signatures/new' do
let(:url) { "/petitions/#{petition.id}/signatures/new" }
let(:petition) { FactoryBot.create(:open_petition) }
let(:params) {
{
'stage' => 'replay-email',
'move' => 'next',
'petition_id' => "#{petition.id}",
'signature' => {
'name' => 'John Mcenroe', 'email' => 'john@example.com',
'postcode' => 'SE3 4LL', 'location_code' => 'GB'
}
}
}
it_behaves_like 'a POST route where failure only supports html formats'
end
context 'a failed post to feedback' do
let(:url) { '/feedback' }
let(:params) { {} }
it_behaves_like 'a POST route where failure only supports html formats'
end
context 'the constituencies url' do
let(:url) { '/constituencies' }
let(:params) { {} }
it 'supports json via extension' do - context(the constituencies url)::it#supports json via extension has a flog score of 26
get url + '.json', params
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'supports json via accepts header' do -
- context(the constituencies url)::it#supports json via accepts header has a flog score of 25
get url, params, {'Accept' => 'application/json'}
expect(response.status).to eq 200
expect(response.content_type).to eq :json
end
it 'does not support xml via extension' do
get url + '.xml', params
expect(response.status).to eq 406
end
it 'does not support xml via accepts header' do -
get url, params, {'Accept' => 'application/xml'}
expect(response.status).to eq 406
end
it 'does not support html via extension' do
get url + '.html', params
expect(response.status).to eq 406
end
it 'does not support html via accepts header' do -
get url, params, {'Accept' => 'text/html'}
expect(response.status).to eq 406
end
it 'does not support html default' do
get url, params
expect(response.status).to eq 406
end
end
end